perf: improve many aspects of DSV performance#1592
Merged
Conversation
AffectedShadowVariable (now NodeTopologicalOrder) is no longer created over and over again.
Collaborator
Author
|
@Christopher-Chianelli I addressed all your comments. Please check the final commit - it seems to have broken a test, although I wasn't able to figure out how. As far as I can tell, the change is functionally equivalent to what was there previously. Please check if you can find out what went wrong - worst case, I revert the final commit. (But I'd rather not to, because that commit takes MJS from 4.5G heap permanently occupied down to 3G.) |
DefaultEdge[][] took 2GB of heap per thread in mid-size MJS problems. Even though it did improve performance, such a hit would have made multi-threading practically impossible. It would have also prevented us from solving large problems.
Collaborator
Author
|
Nevermind, fixed it. |
|
Christopher-Chianelli
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Less memory allocations.
Less map access.
Cleaner code structure.
Commits are cleanly isolated, so that it is possible to review each idea independently.